[ 
https://issues.apache.org/jira/browse/LUCENE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944040#comment-13944040
 ] 

Uwe Schindler commented on LUCENE-5551:
---------------------------------------

Hi,

we should craefull check all this. E.g., I have a problem with the following:

{noformat}
-      final long base = minValues[block] + (long) (averages[block] * (long) 
element);
+      final long base = minValues[block] + (long) (averages[block] * element);
{noformat}

The brackets are strange, because I dont know the data types are correct and if 
the multiplication may overflow.
 So please be careful!

> Fix warnings in the ant build
> -----------------------------
>
>                 Key: LUCENE-5551
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5551
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 4.8
>            Reporter: Shawn Heisey
>             Fix For: 5.0
>
>         Attachments: LUCENE-5551-fix-fallthrough.patch, 
> LUCENE-5551-redundant-casts.patch
>
>
> The build produces a lot of warnings.  LUCENE-5130 aims to fail the build on 
> certain warnings, but until we actually eliminate those warnings from the 
> code, failing the build is premature.
> This issue is concerned with fixing or suppressing warnings reported by the 
> ant build, anything further than that may need one or more separate issues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to