[
https://issues.apache.org/jira/browse/LUCENE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944045#comment-13944045
]
Uwe Schindler commented on LUCENE-5551:
---------------------------------------
FYI, I generally prefer to add a suppress warnings for those cases and don't
change code, because in many cases like this the person who wrote the code had
some intention to have the casts like that. Esspecially when I wrote the code,
I want it explicitly be sure and I have some things to express with my style of
coding.
This is why I don't like Eclipse: it wants to teach me how to code, but I have
my own style of coding. Especially with casts. So I would prefer to let the
long/int casts as they are. Especially if they are explicit. This is not a bug
or warning, its just a different style. So -1 to change int/long casts.
> Fix warnings in the ant build
> -----------------------------
>
> Key: LUCENE-5551
> URL: https://issues.apache.org/jira/browse/LUCENE-5551
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Affects Versions: 4.8
> Reporter: Shawn Heisey
> Fix For: 5.0
>
> Attachments: LUCENE-5551-fix-fallthrough.patch,
> LUCENE-5551-redundant-casts.patch
>
>
> The build produces a lot of warnings. LUCENE-5130 aims to fail the build on
> certain warnings, but until we actually eliminate those warnings from the
> code, failing the build is premature.
> This issue is concerned with fixing or suppressing warnings reported by the
> ant build, anything further than that may need one or more separate issues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]