[ 
https://issues.apache.org/jira/browse/LUCENE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944161#comment-13944161
 ] 

Uwe Schindler commented on LUCENE-5551:
---------------------------------------

Sorry, I did not know that {{averages[block]}} or {{f}} in your example was a 
float - I was expecting that it is an int, too! This makes it more crazy. We 
should be really careful!

This just confirms my problem: The coder had an idea why he casted like that 
:-) Redundant casting is not really a warning, it dont hide bugs, it makes it 
explicit what was intended, so its just there for clarification. Just because 
javac automatically casts something accoring to java standards, it does not 
mean we should really take it as it is. I prefer explicit casts around 
primitive types!

I would suggest to disable the warning in the eclipse config file in 
dev-tools/eclipse!

> Fix warnings in the ant build
> -----------------------------
>
>                 Key: LUCENE-5551
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5551
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 4.8
>            Reporter: Shawn Heisey
>             Fix For: 5.0
>
>         Attachments: LUCENE-5551-fix-fallthrough.patch, 
> LUCENE-5551-redundant-casts.patch
>
>
> The build produces a lot of warnings.  LUCENE-5130 aims to fail the build on 
> certain warnings, but until we actually eliminate those warnings from the 
> code, failing the build is premature.
> This issue is concerned with fixing or suppressing warnings reported by the 
> ant build, anything further than that may need one or more separate issues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to