[ 
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069198#comment-14069198
 ] 

Jack Krupansky commented on SOLR-6260:
--------------------------------------

I noticed that the SolrCore code does in fact default the update handler class 
to DIH2/SIH if the "class" attribute is not specified, so maybe the upgrade 
instructions can simply be for users to "remove the <updateHandler> class 
attribute", rather than for them to have to learn yet another internal name.

And I would reiterate my proposal to remove the "class" attribute from the 
example solrconfig.xml files, for both 5.0 and 4.x.

Either way, the patch should include changes to the "Upgrading" section of 
CHANGES.txt.

Do those three things and then I'm an easy +1!


> Rename DirectUpdateHandler2
> ---------------------------
>
>                 Key: SOLR-6260
>                 URL: https://issues.apache.org/jira/browse/SOLR-6260
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Mark Miller
>            Priority: Minor
>         Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2 
> should be renamed, at least remove that "2". I don't know really what 
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or 
> "UpdateHandlerDefaultImpl", or other good suggestions



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to