[ 
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069029#comment-14069029
 ] 

Yonik Seeley commented on SOLR-6260:
------------------------------------

-1

The benefits to this simple class rename are blown way out of proportion by 
fallaciously linking it to real improvements.  Further, if you're worried about 
attracting new committers, fostering a more civil (and less aggressive and 
combative) environment would go a long way.

Although there are multiple minor downsides (countering the minor upside), I'll 
remove my -1 if we can at least implement back compat with existing 
solrconfigs.  It should be trivial.

> Rename DirectUpdateHandler2
> ---------------------------
>
>                 Key: SOLR-6260
>                 URL: https://issues.apache.org/jira/browse/SOLR-6260
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>         Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2 
> should be renamed, at least remove that "2". I don't know really what 
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or 
> "UpdateHandlerDefaultImpl", or other good suggestions



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to