[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076183#comment-14076183
]
Uwe Schindler commented on LUCENE-5850:
---------------------------------------
Yeah, this is horrible. 4.8.1 is not broken, because I took care of that
before release.
Actually, if we parse this to Version constants, the Lucene Main Version
constant in Constants.java should be of type Version. And Version should be
able to serialize as String according to spec.
I think in the affected versions, the RM used search replace in an
inappropriate way...
The Constants test case should validate the version string with a regex. I
think I already added that, so it should not happen later.
The sys prop hell is only partly related but is there to validate that the
common-build version fits the constant. At runtime it never parses constants.
Lucene never reads the sysprop at runtime.
--
Uwe Schindler
H.-H.-Meier-Allee 63, 28213 Bremen
http://www.thetaphi.de
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850_bomb.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
