[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076440#comment-14076440
]
Hoss Man commented on LUCENE-5850:
----------------------------------
bq. The main problem is caused by the overengineering of this shit: two
different version values, one of which is driven by a system property, and
other confusion. Because of this its also not tested. I realize this system
property shit is supposed to be there to support "strange" things like custom
builds and maven snapshots, but its gotta die. Sorry, its broken for actual
lucene releases!
Agreed: we should absolutely prioritize the stability and correctness of the
official releases over any sort of custom builds and/or maven snapshots -- but
one thing to keep in mind is that a lot of the reason for these "defaults" was
not to make it _easier_ for people to do custom builds or maven snapshots, but
to help ensure that *if* someone does a custom build or uses a maven snapshot
there is no mistaking it from an official build.
ie: way, way back in the day people would build off trunk, with custom patches
and their builds might be named "lucene-1.4.jar" (before 1.4 was ever official)
and then weeks/months later (after 1.4 came out) they (or their coworkers)
reported bugs or asked questions that made no sense and there would be no end
of confusion.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch,
> LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
