[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076504#comment-14076504
]
Robert Muir commented on LUCENE-5850:
-------------------------------------
{quote}
Agreed: we should absolutely prioritize the stability and correctness of the
official releases over any sort of custom builds and/or maven snapshots – but
one thing to keep in mind is that a lot of the reason for these "defaults" was
not to make it easier for people to do custom builds or maven snapshots, but to
help ensure that if someone does a custom build or uses a maven snapshot there
is no mistaking it from an official build.
{quote}
I don't really care about this. The stuff we record in the index needs to be
correct for various back compat to work. If we can't simplify the versioning,
then we need to simplify our back compat guarantee. But something has to give.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch,
> LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
