[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077649#comment-14077649
]
Mark Miller commented on LUCENE-5850:
-------------------------------------
bq. We need only one version here. Currently the shit is overengineered and
does not really work, even committers are screwing it up. To hell with maven
builds, custom builds, etc, we have to fix this
I'm too high level on this to fully understand atm, so excuse my laziness, but
can't we still basically support custom builds even with only one version?
Can't they just override this one version?
Even the ways things are now, we are working around issues with our custom
build and replacing the version. I've had to comment out a few of those version
check tests. I've talked about it with Robert before and it did all just seem
to be kind of silly. Glad it's all getting overhauled.
Just trying to understand why custom build would be too difficult anyway. I
mean, perhaps you have to make a small hack to the ant file or something, but
that's fine.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch,
> LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
