[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079503#comment-14079503
]
Hoss Man commented on LUCENE-5859:
----------------------------------
bq. we can at least make no-arg ctors forwarding to VERSION_CURRENT so that
people who don't care about back compat (e.g. just prototyping) don't have to
deal with the horribly complex versioning system.
+1 .. As long as we have some boilerplate javadocs on all of these constructors
("The runtime behavior of this class may change btween releases when using this
constructor, please consider the 'Version' constructor to maximize
compatibility between releases") this seems like a good idea.
bq. I tried to be reasonable here and open an issue with a compromise. Its
clear this is a mistake. I'm now going down the path of removing Version
completely.
Your proposal seems very reasonable -- but you also seem to have gotten very
antagonistic and unreasonable when Shai suggested his own, reasonable,
alternative proposal for discussion.
I happen to prefer your proposal to the one Shai made, but you are not coming
across, to me, as being very reasonable in your response.
> Remove Version.java completely
> ------------------------------
>
> Key: LUCENE-5859
> URL: https://issues.apache.org/jira/browse/LUCENE-5859
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 5.0
>
>
> This has always been a mess: analyzers are easy enough to make on your own,
> we don't need to "take responsibility" for the users analysis chain for 2
> major releases.
> The code maintenance is horrible here.
> This creates a huge usability issue too, and as seen from numerous mailing
> list issues, users don't even understand how this versioning works anyway.
> I'm sure someone will whine if i try to remove these constants, but we can at
> least make no-arg ctors forwarding to VERSION_CURRENT so that people who
> don't care about back compat (e.g. just prototyping) don't have to deal with
> the horribly complex versioning system.
> If you want to make the argument that doing this is "trappy" (i heard this
> before), i think thats bogus, and ill counter by trying to remove them.
> Either way, I'm personally not going to add any of this kind of back compat
> logic myself ever again.
> Updated: description of the issue updated as expected. We should remove this
> API completely. No one else on the planet has APIs that require a mandatory
> version parameter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]