[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079793#comment-14079793
]
Mark Miller commented on LUCENE-5859:
-------------------------------------
bq. and yet there are -1's to clean this stuff up :)
Let's not over-blow a -1. It has gotten so conflated with a veto these days. By
my reading, it means, "I don't currently agree with this".
We can't skip the step of trying to convince people of an argument and just go
to throwing up our hands and saying "there is no convincing anybody". I think
people want to be on board with a lot of these ideas, but you are making it
harder than it needs to be.
I'm easily sold on the better constructers. I'm willing to be convinced on the
broader version thing in general.
bq. So I suppose you are volunteering to fix StandardAnalyzer on trunk to be
backwards compatible with 4.0-4.6?
I'm pretty open to the idea that everything can break over major versions...
> Remove Version.java completely
> ------------------------------
>
> Key: LUCENE-5859
> URL: https://issues.apache.org/jira/browse/LUCENE-5859
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 5.0
>
>
> This has always been a mess: analyzers are easy enough to make on your own,
> we don't need to "take responsibility" for the users analysis chain for 2
> major releases.
> The code maintenance is horrible here.
> This creates a huge usability issue too, and as seen from numerous mailing
> list issues, users don't even understand how this versioning works anyway.
> I'm sure someone will whine if i try to remove these constants, but we can at
> least make no-arg ctors forwarding to VERSION_CURRENT so that people who
> don't care about back compat (e.g. just prototyping) don't have to deal with
> the horribly complex versioning system.
> If you want to make the argument that doing this is "trappy" (i heard this
> before), i think thats bogus, and ill counter by trying to remove them.
> Either way, I'm personally not going to add any of this kind of back compat
> logic myself ever again.
> Updated: description of the issue updated as expected. We should remove this
> API completely. No one else on the planet has APIs that require a mandatory
> version parameter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
