[ 
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079602#comment-14079602
 ] 

Mark Miller commented on LUCENE-5859:
-------------------------------------

bq. but we can at least make no-arg ctors forwarding to VERSION_CURRENT 

+1

bq. I'm not against the proposal here, just raising some concerns that I have. 
bq. I tried to be reasonable here and open an issue with a compromise. Its 
clear this is a mistake. 
bq. but you also seem to have gotten very antagonistic and unreasonable 

+1. Less coffee Rob :)

Doesn't seem like much is in your way yet, keep the pin in the grenade for 
later.

Let's start with some sane constructors before we nuke the whole system. I half 
way know the versioning system, and every time I've tried to toss together some 
quick Lucene code it has really annoyed me to deal with this. Good doc issue 
IMO.


> Remove Version.java completely
> ------------------------------
>
>                 Key: LUCENE-5859
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5859
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 5.0
>
>
> This has always been a mess: analyzers are easy enough to make on your own, 
> we don't need to "take responsibility" for the users analysis chain for 2 
> major releases.
> The code maintenance is horrible here.
> This creates a huge usability issue too, and as seen from numerous mailing 
> list issues, users don't even understand how this versioning works anyway.
> I'm sure someone will whine if i try to remove these constants, but we can at 
> least make no-arg ctors forwarding to VERSION_CURRENT so that people who 
> don't care about back compat (e.g. just prototyping) don't have to deal with 
> the horribly complex versioning system.
> If you want to make the argument that doing this is "trappy" (i heard this 
> before), i think thats bogus, and ill counter by trying to remove them. 
> Either way, I'm personally not going to add any of this kind of back compat 
> logic myself ever again.
> Updated: description of the issue updated as expected. We should remove this 
> API completely. No one else on the planet has APIs that require a mandatory 
> version parameter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to