[ 
https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972108#action_12972108
 ] 

Robert Muir commented on SOLR-2288:
-----------------------------------

bq. Robert: as mentioned, i'm trying to keep a narrow focus on this issue: 
dealing with warnings that can be cleaned up w/o changing functionality...

Ok but i didnt change the functionality? the functionality is the same, just 
the implementation is different.

This is the root cause of most of the compiler warnings, let's not dodge the 
issue.




> clean up compiler warnings
> --------------------------
>
>                 Key: SOLR-2288
>                 URL: https://issues.apache.org/jira/browse/SOLR-2288
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch
>
>
> there's a ton of compiler warning in the solr tree, and it's high time we 
> cleaned them up, or annotate them to be suppressed so we can start making a 
> bigger stink when/if code is added to the tree thta produces warnings (we'll 
> never do a good job of noticing new warnings when we have ~175 existing ones)
> Using this issue to track related commits
> The goal of this issue should not be to change any functionality or APIs, 
> just deal with each warning in the most appropriate way;
> * fix generic declarations
> * add SuppressWarning anotation if it's safe in context

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to