[ 
https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979022#action_12979022
 ] 

Hoss Man commented on SOLR-2288:
--------------------------------


In the absence of any direct object to the approach taken in my initial patch 
(i even solicited feedback from the generics policeman multiple times on IRC 
over the past few weeks) I went ahead and commited to trunk...

Committed revision 1056558.

as mentioned before, i'm going continue on with similar easy fixes around the 
tree w/o bothering to post patches to jira -- we can use CTR if anyone has 
concerns about specific changes.

eventually i'd like to try and port some of this to 3x, but that's a lower 
priority

> clean up compiler warnings
> --------------------------
>
>                 Key: SOLR-2288
>                 URL: https://issues.apache.org/jira/browse/SOLR-2288
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch
>
>
> there's a ton of compiler warning in the solr tree, and it's high time we 
> cleaned them up, or annotate them to be suppressed so we can start making a 
> bigger stink when/if code is added to the tree thta produces warnings (we'll 
> never do a good job of noticing new warnings when we have ~175 existing ones)
> Using this issue to track related commits
> The goal of this issue should not be to change any functionality or APIs, 
> just deal with each warning in the most appropriate way;
> * fix generic declarations
> * add SuppressWarning anotation if it's safe in context

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to