[
https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973791#action_12973791
]
Hoss Man commented on SOLR-2288:
--------------------------------
bq. can we just use: NamedList<?> rather then bind it explicitly to Object?
i *think* in the changes i made so far i used "?" every place i could. Binding
to "?" is appropriate when you don't care what the typevar is, but "Object" is
what you have to use when you know you are dealing with a collection of
heterogenous objects -- which is many uses of NamedList.
in the cases where the code was dealing with a NamedList of homogeneous
objects, i used the specific homogeneous type (ie:
"NamedList<NamedList<String>>")
That said: there certainly may be places where i could have used NamedList<?>
and didn't realize it.
> clean up compiler warnings
> --------------------------
>
> Key: SOLR-2288
> URL: https://issues.apache.org/jira/browse/SOLR-2288
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch
>
>
> there's a ton of compiler warning in the solr tree, and it's high time we
> cleaned them up, or annotate them to be suppressed so we can start making a
> bigger stink when/if code is added to the tree thta produces warnings (we'll
> never do a good job of noticing new warnings when we have ~175 existing ones)
> Using this issue to track related commits
> The goal of this issue should not be to change any functionality or APIs,
> just deal with each warning in the most appropriate way;
> * fix generic declarations
> * add SuppressWarning anotation if it's safe in context
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
