[ 
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144498#comment-14144498
 ] 

Noble Paul commented on SOLR-6476:
----------------------------------

bq.The bulk schema api should be added to TestCloudManagedSchemaConcurrent

Why can't it be in a new class?

bq.TestBulkSchemaAPI has lots of backslash-double-quotes in JSON strings

That was deliberate. Most JSON writers use double quotes. 

bq.In SchemaManager.doOperation(), you limit retries to MAX_TRIES

I can make the variable bigger , but I somehow hate infinite loops

bq.SchemaManager.ADD_FIELD_TYPE should be "add-field-type" 

sure

bq.SchemaManager has lots of non-generic collections 

will fix them

bq.IndexSchema.addDynamicFields() is missing the persist param you added to all 
the other add*() methods; 

will fix

bq.Most of the add*() javadocs in IndexSchema say that persistence always 
happens, but it doesn't if persist=false

will fix





> Create a bulk mode for schema API
> ---------------------------------
>
>                 Key: SOLR-6476
>                 URL: https://issues.apache.org/jira/browse/SOLR-6476
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>              Labels: managedResource
>         Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, 
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is 
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example 
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H 
> 'Content-type:application/json'  -d '{
>     "add-field": {
>         "name":"sell-by",
>         "type":"tdate",
>         "stored":true
>     },
>     "add-field":{
>         "name":"catchall",
>         "type":"text_general",
>         "stored":false
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to