[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147819#comment-14147819
]
Steve Rowe commented on SOLR-6476:
----------------------------------
{quote}
bq. The bulk schema api should be added to TestCloudManagedSchemaConcurrent
Why can't it be in a new class?
{quote}
It can, but you don't have any distributed tests at all. All existing schema
API modification functionality gets distributed testing via
{{TestCloudManagedSchemaConcurrent}} at this point.
{quote}
bq. {{TestBulkSchemaAPI}} has lots of backslash-double-quotes in JSON strings
That was deliberate. Most JSON writers use double quotes.
{quote}
You misunderstand me: {{SolrTestCaseJ4.json(String)}} converts single-quotes to
double-quotes. Several Solr tests use it to get most-JSON-writer-compatible
output without causing backslash-eye-bleed. I'm suggesting you do the same.
{quote}
bq. In SchemaManager.doOperation(), you limit retries to MAX_TRIES
I can make the variable bigger , but I somehow hate infinite loops
{quote}
It keeps retrying when another schema modification request gets in first.
Please fix this - you didn't change anything at all here. There is no way we
should be giving up here just because other modifications are happening.
{quote}
bq. SchemaManager.ADD_FIELD_TYPE should be "add-field-type"
sure
{quote}
bq. I also want to ask the preference of "add-field" Vs "addField" in the
command names
Thanks - I like "add-field" better, but either would be fine.
{quote}
bq. {{SchemaManager}} has lots of non-generic collections
will fix them
{quote}
I only see one modification here (you added {{<String>}} on the left hand side
but forgot to put in the diamond operator on the right side), still lots of
non-generic collection usages - is there a problem with fixing the others?
{quote}
bq. Most of the add*() javadocs in IndexSchema say that persistence always
happens, but it doesn't if persist=false
We need to remove those methods without persist option
{quote}
You removed some sugar methods, specifically for adding a single dynamic field,
but left other sugar methods intact, e.g. {{addField()}} - why the
inconsistency? I personally think sugar methods are fine - that's why I put
them there - but if you're going to remove them, please be consistent.
And the javadocs are still wrong:
# the persist param isn't listed on {{addFieldTypes()}} and
{{addDynamicFields()}}
# the javadocs for all the methods say the methods will always persist. This
is wrong.
> Create a bulk mode for schema API
> ---------------------------------
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Noble Paul
> Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
