[
https://issues.apache.org/jira/browse/LUCENE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980553#action_12980553
]
Jason Rutherglen commented on LUCENE-2856:
------------------------------------------
bq. I think start/endTime can be long and not Long?
Long's used because it allows null.
{quote}Maybe instead of adding init/start/endTime to OneMerge, you can pass a
'time' parameter to MergeEvent. So its signature will be MergeEvent(Type type,
long time, OneMerge merge). The 'time' parameter can then be interpreted
according to Type.
Even better, I think you can remove that parameter entirely, and have
MergeEvent call System.currentTimeMillis() and set its internal member
according to Type?{quote}
I think it's generally useful to keep track of the time(s) in the OneMerge
object. It's implemented this way so that the, likely a user interface does
not need to store the various times itself. Actually, logging applications
also need to print the durations.
bq. I did notice that SegmentInfo's cache is potentially buggy - it doesn't
take into account 'includeDocStores'.
Yes, that'd be good to fix.
> Create IndexWriter event listener, specifically for merges
> ----------------------------------------------------------
>
> Key: LUCENE-2856
> URL: https://issues.apache.org/jira/browse/LUCENE-2856
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Attachments: LUCENE-2856.patch
>
>
> The issue will allow users to monitor merges occurring within IndexWriter
> using a callback notifier event listener. This can be used by external
> applications such as Solr to monitor large segment merges.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
