[ 
https://issues.apache.org/jira/browse/LUCENE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983155#action_12983155
 ] 

Michael McCandless commented on LUCENE-2856:
--------------------------------------------

The ReaderEvent is never generated?  Is that still work-in-progress?
When would this be invoked? Only if IW is pooling readers?  Maybe we
should hold off on that for a separate issue?

Why were the added checks needed in SegmentInfo?  Oh I see, it's
because you compute the sizeInBytes of the merged segment before the
merge completes... hmm.  I think I'd prefer that this SegmentInfo not
be published until the Type == COMPLETE.

How come merge is not also final in MergeEvent?

I agree we should change the name.  IndexEventListener?

I don't think we need CompositeSegmentListener?  Why not an API to
just add/remove listeners?  Also: are we sure this belongs in IWC?
This is analogous to "infoStream", which is on IW.  It's not a config
parameter that affects indexing.

Should we also track "segment flushed/aborted" events?

Can you add some jdocs and mark the API as experimental?


> Create IndexWriter event listener, specifically for merges
> ----------------------------------------------------------
>
>                 Key: LUCENE-2856
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2856
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Jason Rutherglen
>         Attachments: LUCENE-2856.patch, LUCENE-2856.patch, LUCENE-2856.patch
>
>
> The issue will allow users to monitor merges occurring within IndexWriter 
> using a callback notifier event listener.  This can be used by external 
> applications such as Solr to monitor large segment merges.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to