[ 
https://issues.apache.org/jira/browse/LUCENE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980558#action_12980558
 ] 

Shai Erera commented on LUCENE-2856:
------------------------------------

bq. Long's used because it allows null.

I see. We could go with a -1 setting also - I see no reason to allocate an 
object, and use auto-boxing as we do that :).

bq. I think it's generally useful to keep track of the time(s) in the OneMerge 
object.

I'm not going to argue too much about that point - was just thinking that 
OneMerge is already filled with members and it'd be nice if we can add more to 
it. As for the logging scenario, I think that with the 
CompositeSegmentsListener an application can easily plug in its SL for logging 
purposes. But as I said, I don't mind about it too much.

BTW, I think SegmentListener is not the proper name? I.e., it does not listen 
on Segments, right? Maybe a SegmentMergeListener, or simple a MergeListener? It 
anyway accepts only a MergeEvent ....

> Create IndexWriter event listener, specifically for merges
> ----------------------------------------------------------
>
>                 Key: LUCENE-2856
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2856
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Jason Rutherglen
>         Attachments: LUCENE-2856.patch
>
>
> The issue will allow users to monitor merges occurring within IndexWriter 
> using a callback notifier event listener.  This can be used by external 
> applications such as Solr to monitor large segment merges.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to