[
https://issues.apache.org/jira/browse/LUCENE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492039#comment-14492039
]
Adrien Grand commented on LUCENE-6373:
--------------------------------------
The patch looks like a good start, it's good to see SpanOr and disjunctions
looking similar.
bq. //final long cost; //FIXME: needed?
This is needed by the min-should-match scorer in order to keep track of scorers
which are behind the current document and advance the least-costly instance
first.
Also a minor nitpick but I think we should move SpanPositionQueue to either its
own java file or as an inner class of SpanOrQuery in order not to confuse
incremental compilation.
Maybe "Specialize SpanPositionQueue similar to DisiPriorityQueue, inline the
position comparison function." could be delayed to another issue in order to
keep this one small?
> Complete two phase doc id iteration support for Spans
> -----------------------------------------------------
>
> Key: LUCENE-6373
> URL: https://issues.apache.org/jira/browse/LUCENE-6373
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Attachments: LUCENE-6373-SpanOr.patch
>
>
> Spin off from LUCENE-6308, see comments there from about 23 March 2015.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
