[ 
https://issues.apache.org/jira/browse/LUCENE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492564#comment-14492564
 ] 

Paul Elschot commented on LUCENE-6373:
--------------------------------------

Robert,

bq. And if the long term goal is to merge the functionality of Spans into 
Scorer anyway,

I think that we need some scoring mechanism added to Spans, and that completely 
merging Spans with Scorer will not happen. But we'll see.

bq. then i'd prefer the instanceof check for now, rather than adding it to 
DISI, then having to take it away from DISI and put back into Scorer later.

I don't mind the instanceof checks, but I do mind having the same code for it 
twice.
Shall I put it in an in between class TwoPhaseDISI (superclass of Scorer and 
Spans) so other DISI subclasses are not involved?
That would continue the merging  :)


> Complete two phase doc id iteration support for Spans
> -----------------------------------------------------
>
>                 Key: LUCENE-6373
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6373
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>         Attachments: LUCENE-6373-SpanOr.patch
>
>
> Spin off from LUCENE-6308, see comments there from about 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to