On Thu, May 21, 2015 at 6:40 PM, Yonik Seeley <ysee...@gmail.com> wrote:
> It's my opinion that it also wastes everyones time to force them to > have a pristine checkout before committing > I guess there are two kinds of checks which `ant precommit` tries to combine -- one is checks which influence the quality/correctness of the code which is checked in, and that's probably the vast majority. The stray files check is more of a "commit helper", whose impact is limited to the developers working copy, if you violate it and miss files, it should really trigger other issues like compilation or tests in jenkins. I don't know if there are others which fall into this category. One way out may be to remove the stray files check from precommit and instead provide a different wrapper script or ant target which wraps around `svn ci`. That could interactively show unversioned files, and ask questions like "do you really want to go ahead" and if you say, commit it anyway. Also, have we tried pre-commit hooks before? It certainly won't do all of pre-commit but way we can move some of the svn checks like eol-style etc. there and those can be mandatory.
