On Wed, Feb 16, 2011 at 12:06 AM, Smiley, David W. <[email protected]> wrote: > I may have added a test just now, but I and others have been using this > [simple] code for some time now. It has "baked", it doesn't need more baking > IMO.
I am sure people will say I am just being silly, but hudson does a better job testing these things than people playing with the code. For example, hudson randomizes external variables (locale X timezone)... on the latest 1.6u23 there are 152 locales, and 609 timezones (only 424 "unique" according to raw offset + rules). With hudson selecting 1 of these ~ 65K possibilities 96 times a day, you can start to calculate how long is a good "baking" for date-related functionality. Someone can argue that because Solr insists on treating dates internally, that this does not matter, but I have found and fixed timezone and localization related bugs in Lucene and Solr before, so that argument fails... not knowing the surrounding code, nothing makes me feel better than a couple weeks of hudson grinding on the code. Even then, sometimes a few weeks isnt enough.. for example if I remember right, SOLR-1821 was daylight-savings related (note: the issue was reported the very day daylight savings started in the United States, but in other timezones it had not yet, and would fail for some developers but not others). > If this patch wasn't the biggest reason to not use distributed search (a key > feature) then I wouldn't be here arguing my point. But I've apparently lost > this argument already so I give up;... assign if for 3.2 if that's the best > you can do Rob. It's better than being unassigned which is what it is now. > I don't think that would be the best, as its not my area of expertise. If I see good patches being ignored because other devs are time-constrained sometimes I will take the time to try to bring myself up to speed to get them committed though, but I haven't yet given up on this patch :) Just so you know, Its nothing about your patch at all, I am just against any new features of any sort being added to 3.1 at this point. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
