Clearly to me, the facet bug is a critical one to get into the release (and so is index corruption) and I'm glad it was caught in time to make it into this release. I think these are the only "critical" issues I'm aware of so I'm not concerned about "the floodgates opening" unless I hear of other clearly non-critical issues jump on too.
Thanks for doing the release Adrien! ~ David On Sat, Jan 16, 2016 at 8:24 PM Erick Erickson <erickerick...@gmail.com> wrote: > bq: How is this issue critical? > > Well, a heck of a lot of clients I deal with use facets to do analysis > of their corpi, think of it as "poor man's stats". To tell them that > "well, the facet counts will not be accurate sometimes" is a tough > pill to swallow. > > Where we're at with this is essentially telling Solr users "skip all > 5.3 and 5.4 versions if you want your facet counts to be accurate". > Which sets the bar for releasing a 5.5 I guess. > > That said I can deal with some fuzziness on facet counts, but I really > can't deal with index corruption so I guess it's a judgement call. > > > > On Sat, Jan 16, 2016 at 11:41 AM, Robert Muir <rcm...@gmail.com> wrote: > > I don't think we should open the floodgates. How is this issue critical? > > > > We need to get the index corruption fix out. +1 to release as is. > > > > On Sat, Jan 16, 2016 at 11:03 AM, Ramkumar R. Aiyengar > > <andyetitmo...@gmail.com> wrote: > >> I missed the initial RC, but if we are going to re-spin (and looks like > >> Yonik has a patch up now), I would like to back-port SOLR-8418. Should > be > >> fairly benign, let me know if there are any concerns.. > >> > >> On Fri, Jan 15, 2016 at 5:59 PM, Adrien Grand <jpou...@gmail.com> > wrote: > >>> > >>> Thanks Yonik, let's see what this bug boils down to and how quickly we > can > >>> get it fixed. > >>> > >>> Le ven. 15 janv. 2016 à 17:15, Yonik Seeley <ysee...@gmail.com> a > écrit : > >>>> > >>>> We've discovered a very serious bug, currently unknown how deep it > >>>> runs, but may make sense to respin if we can get it ironed out quickly > >>>> enough: > >>>> https://issues.apache.org/jira/browse/SOLR-8496 > >>>> > >>>> -Yonik > >>>> > >>>> > >>>> On Thu, Jan 14, 2016 at 5:41 AM, Adrien Grand <jpou...@gmail.com> > wrote: > >>>> > Please vote for the RC1 release candidate for Lucene/Solr 5.4.1 > >>>> > > >>>> > The artifacts can be downloaded from: > >>>> > > >>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.1-RC1-rev1724447/ > >>>> > > >>>> > You can run the smoke tester directly with this command: > >>>> > python3 -u dev-tools/scripts/smokeTestRelease.py > >>>> > > >>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.1-RC1-rev1724447/ > >>>> > > >>>> > The smoke tester already passed for me both with the local and > remote > >>>> > artifacts, so here is my +1. > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >>>> For additional commands, e-mail: dev-h...@lucene.apache.org > >>>> > >> > >> > >> > >> -- > >> Not sent from my iPhone or my Blackberry or anyone else's > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
