[
https://issues.apache.org/jira/browse/LUCENE-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221608#comment-15221608
]
Robert Muir commented on LUCENE-7157:
-------------------------------------
A few things:
1. the fact that polygon has some 2d methods in it. I think its far too much to
ask for me to worry about "2d and 3d at once" with LUCENE-7153. It is important
users can do queries without using gigabytes of RAM. And additional 2d methods
on this class are really not in your way, just ignore them.
2. the fact that mike suggested on LUCENE-7153 to fork the polygon class, but
now I hear you don't like things about it, or it won't work for you (not sure
which it really is: if its just some extra methods really bothering you but not
hurting you, or if you really need changes). I think we should not do this
forking, i do not agree with him there.
3. the fact this polygon logic may have bugs. Both GeoPointField and
LatLonPoint boldly declare that these lat/lon arrays must be in clockwise or
counterclockwise order. That is what their javadocs say. So if things aren't
working, then thats a bug but we need tests and stuff, not "the math doesnt
look right to me".
I don't mean to be terse but there are a lot of other bugs (e.g. this
quantization happening at least in 2d land is an *absolute disaster*) and so
problems where "I dont like the way it looks", well, to me thats not serious.
> Geo3DPoint implementation should pay attention to the ordering of lat/lon
> points
> --------------------------------------------------------------------------------
>
> Key: LUCENE-7157
> URL: https://issues.apache.org/jira/browse/LUCENE-7157
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Karl Wright
>
> The LatLonPoint API implementation pays attention to the order of the points;
> "clockwise" means one side of the polygon boundary, and "counterclockwise"
> means the complement. We need to use that in Geo3DPoint and convert into
> whatever the underlying GeoPolygonFactory method requires.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
