Hi Adrien, Thanks for your reply. I renamed the JIRA issue to address a specific FindBugs problem, will raise more issues for other problems. Regards, Daniel
2017-03-12 18:31 GMT+01:00 Adrien Grand <[email protected]>: > Hi Daniel, > > Thanks for helping! I'm currently away so I can't test your LUCENE-7739 > patch but at first sight it looks good. I think patches that cover the > entire codebase are ok however we tend to have a 1-1 mapping between issues > and patches so I think you should open new issues if you want to address > new kinds of Findbugs-reported issues in the future. Does it make sense to > you? > > Le dim. 12 mars 2017 à 03:22, Daniel Jeliński <[email protected]> a > écrit : > >> Hi all, >> I started fixing code issues reported by Findbugs; right now it is >> reporting 4000+ issues in lucene/solr repository. I could use some guidance: >> 1) Will one JIRA issue be sufficient to cover all Findbugs-related items, >> or should I raise separate items for distinct problems reported by >> Findbugs? I raised LUCENE-7739 as a catch-all issue, but I can split it if >> that's preferred. >> 2) My plan is to fix trivial issues first, then work on the harder ones. >> I already sent a patch to fix issues related to unnecessary boxing/unboxing >> when parsing strings. That patch covers the entire codebase, but in my >> opinion it's fairly straightforward. Is that acceptable, or should I split >> the patch somehow? Like, lucene/solr, or one file at a time, or one issue >> at a time or... >> >> Ideas welcome. >> Regards, >> Daniel >> >
