Hi Daniel, I had opened SOLR-10080 a while back. I think Christine Porsche did pick up one small change from the, there are few things that still need to be looked over and address. I have added comments/questions in the patch when I had doubts. Patch addressed issues at solr package level
I was working on another patch for Lucerne and you can find it at https://github.com/praste/lucene-solr/tree/findbugs-lucene?files=1 Feel free to take a look at it. On Mar 11, 2017 6:22 PM, "Daniel Jeliński" <[email protected]> wrote: > Hi all, > I started fixing code issues reported by Findbugs; right now it is > reporting 4000+ issues in lucene/solr repository. I could use some guidance: > 1) Will one JIRA issue be sufficient to cover all Findbugs-related items, > or should I raise separate items for distinct problems reported by > Findbugs? I raised LUCENE-7739 as a catch-all issue, but I can split it if > that's preferred. > 2) My plan is to fix trivial issues first, then work on the harder ones. I > already sent a patch to fix issues related to unnecessary boxing/unboxing > when parsing strings. That patch covers the entire codebase, but in my > opinion it's fairly straightforward. Is that acceptable, or should I split > the patch somehow? Like, lucene/solr, or one file at a time, or one issue > at a time or... > > Ideas welcome. > Regards, > Daniel >
