Github user m-khl commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r119993106
--- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java ---
@@ -142,6 +142,11 @@ public boolean hasNext() {
return docIterator.hasNext();
}
+ // called at the end of the stream
--- End diff --
can't we leverage Closeable here and get some sugar&warns?
Also, line 89 still calls setContext() .. is it right? or I'm missing
something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
