Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/275#discussion_r153109215
--- Diff:
solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ---
@@ -539,6 +564,25 @@ protected Query newRegexpQuery(Term regexp) {
return query;
}
+ @Override
+ protected Query newSynonymQuery(Term terms[]) {
+ if (scoreOverlaps == ScoreOverlaps.PICK_BEST) {
--- End diff --
Some nitpicks here. I think a switch/case statement would better reflect
this code reacts to all possibilities of scoreOverlaps. Secondly, the `new
ArrayList<Query>()` could be `new ArrayList<>(terms.length)`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
