Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/275#discussion_r154456952
  
    --- Diff: 
solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java ---
    @@ -1057,7 +1057,35 @@ public void testShingleQueries() throws Exception {
             , "/response/numFound==1"
         );
       }
    -  
    +
    +
    +  public void testSynonymQueryStyle() throws Exception {
    +    ModifiableSolrParams edismaxParams = params("qf", "t_pick_best_foo");
    --- End diff --
    
    Just a minor point here but you needn't have a SolrParams based variable; 
you could simply inline it at each invocation.  This makes it easier to read 
each test request.  If you were trying to share some common params across test 
invocations then I could understand.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to