Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/385#discussion_r191975716
  
    --- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java 
---
    @@ -146,17 +146,14 @@ public String getPrintableId() {
          return "(null)";
        }
     
    -  /**
    -   * @return String id to hash
    -   */
    -  public String getHashableId() {
    +  public String getHashableId(SolrInputDocument doc) {
    --- End diff --
    
    why did you change the method signature to be overloaded and take the solr 
doc?  It's only called once.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to