Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/385#discussion_r191807600
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -184,14 +179,7 @@ public String getHashableId() {
return getHashableId(solrDoc);
}
- public List<SolrInputDocument> getDocsList() {
- if (docsList == null) {
- buildDocsList();
- }
- return docsList;
- }
-
- private void buildDocsList() {
+ public List<SolrInputDocument> computeFlattenedDocs() {
List<SolrInputDocument> all = flatten(solrDoc);
String idField = getHashableId();
--- End diff --
rename rootId? "field" feels very wrong in this variable name.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
