Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/385#discussion_r191805956
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -206,13 +194,13 @@ private void buildDocsList() {
// TODO: if possible concurrent modification exception (if
SolrInputDocument not cloned and is being forwarded to replicas)
// then we could add this field to the generated lucene document
instead.
}
- docsList = all;
+ return all;
}
private List<SolrInputDocument> flatten(SolrInputDocument root) {
List<SolrInputDocument> unwrappedDocs = new ArrayList<>();
if(root.hasChildDocuments()) {
--- End diff --
this condition/guard isn't needed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
