Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/410#discussion_r199384693 --- Diff: solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessor.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.update.processor; + +import java.io.IOException; +import java.util.Objects; + +import org.apache.solr.common.SolrException; +import org.apache.solr.common.SolrInputDocument; +import org.apache.solr.common.SolrInputField; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.solr.schema.IndexSchema; +import org.apache.solr.update.AddUpdateCommand; + +public class NestedUpdateProcessor extends UpdateRequestProcessor { + public static final String PATH_SEP_CHAR = "/"; + private boolean storePath; + private boolean storeParent; + SolrQueryRequest req; + + + protected NestedUpdateProcessor(SolrQueryRequest req, SolrQueryResponse rsp, boolean storeParent, boolean storePath, UpdateRequestProcessor next) { + super(next); + this.req = req; + this.storeParent = storeParent; + this.storePath = storePath; + } + + @Override + public void processAdd(AddUpdateCommand cmd) throws IOException { + SolrInputDocument doc = cmd.getSolrInputDocument(); + String rootId = doc.getField(req.getSchema().getUniqueKeyField().getName()).getFirstValue().toString(); + processDocChildren(doc, rootId, null); + super.processAdd(cmd); + } + + private void processDocChildren(SolrInputDocument doc, String rootId, String fullPath) { + int childNum = 0; + for(SolrInputField field: doc.values()) { + for(Object val: field) { + if(val instanceof SolrInputDocument) { + if(field.getName().contains(PATH_SEP_CHAR)) { + throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "Field name: '" + field.getName() + + "' contains: '" + PATH_SEP_CHAR + "' , which is reserved for the nested URP"); + } + final String jointPath = Objects.isNull(fullPath) ? field.getName(): String.join(PATH_SEP_CHAR, fullPath, field.getName()); + SolrInputDocument cDoc = (SolrInputDocument) val; + if(!cDoc.containsKey(req.getSchema().getUniqueKeyField().getName())) { + cDoc.setField(req.getSchema().getUniqueKeyField().getName(), generateChildUniqueId(rootId, jointPath, childNum)); + } + processChildDoc((SolrInputDocument) val, doc, rootId, jointPath); + } + ++childNum; + } + } + } + + private void processChildDoc(SolrInputDocument sdoc, SolrInputDocument parent, String rootId, String fullPath) { + if(storePath) { + setPathField(sdoc, fullPath); + } + if (storeParent) { + setParentKey(sdoc, parent); + } + processDocChildren(sdoc, rootId, fullPath); + } + + private String generateChildUniqueId(String rootId, String childPath, int childNum) { + return String.join(PATH_SEP_CHAR, rootId, childPath, Integer.toString(childNum)); --- End diff -- This will not necessarily generate a uniqueId. Imagine their are two "page" children on the top book, and both pages have a "footnote" child. They would both get the same ID? BTW I find it really helpful for such methods like this if it has a comment showing an example ID. Perhaps the ID should be simply "/{label}#{childNum}" appended to whatever the ID is of the the parent of this doc is?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org