Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224283996
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,10 @@ public static SolrInputDocument
getInputDocument(SolrCore core, BytesRef idBytes
* @param resolveFullDocument In case the document is fetched from the
tlog, it could only be a partial document if the last update
* was an in-place update. In that case, should this
partial document be resolved to a full document (by following
* back prevPointer/prevVersion)?
+ * @param resolveBlock Check whether the document is part of a block. If
so, return the whole block.
*/
public static SolrInputDocument getInputDocument(SolrCore core, BytesRef
idBytes, AtomicLong versionReturned, boolean avoidRetrievingStoredFields,
- Set<String> onlyTheseNonStoredDVs, boolean resolveFullDocument)
throws IOException {
+ Set<String> onlyTheseNonStoredDVs, boolean resolveFullDocument,
boolean resolveBlock) throws IOException {
SolrInputDocument sid = null;
--- End diff --
It would be helpful to add a javadoc comment to say that if the id refers
to a nested document (which isn't known up-front), then it'll never be found in
the tlog (at least if you follow the rules of nested docs). Also, perhaps the
parameter "resolveBlock" should be "resolveToRootDocument" since I think the
"root" terminology may be more widely used as it's even in the schema, whereas
"block" is I think not so much. If you disagree, a compromise may be to use
both "root" and "Block" together -- "resolveRootBlock".
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
