Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224300831
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -639,12 +650,30 @@ public static SolrInputDocument
getInputDocument(SolrCore core, BytesRef idBytes
sid = new SolrInputDocument();
} else {
Document luceneDocument = docFetcher.doc(docid);
- sid = toSolrInputDocument(luceneDocument,
core.getLatestSchema());
+ sid = toSolrInputDocument(luceneDocument, schema);
}
- if (onlyTheseNonStoredDVs != null) {
- docFetcher.decorateDocValueFields(sid, docid,
onlyTheseNonStoredDVs);
- } else {
- docFetcher.decorateDocValueFields(sid, docid,
docFetcher.getNonStoredDVsWithoutCopyTargets());
+ ensureDocDecorated(onlyTheseNonStoredDVs, sid, docid, docFetcher,
resolveBlock || schema.hasExplicitField(IndexSchema.NEST_PATH_FIELD_NAME));
+ SolrInputField rootField;
--- End diff --
no big deal to simply initialize rootField up front. You are doing it as
an expression with a side-effect below which is needlessly awkward.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
