[
https://issues.apache.org/jira/browse/SOLR-13727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921677#comment-16921677
]
Yonik Seeley commented on SOLR-13727:
-------------------------------------
Changes look good to me! I'll commit soon unless anyone else sees an issue with
this approach.
> V2Requests: HttpSolrClient replaces first instance of "/solr" with "/api"
> instead of using regex pattern
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13727
> URL: https://issues.apache.org/jira/browse/SOLR-13727
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java, v2 API
> Affects Versions: 8.2
> Reporter: Megan Carey
> Priority: Major
> Labels: easyfix, patch
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When the HttpSolrClient is formatting a V2Request, it needs to change the
> endpoint from the default "/solr/..." to "/api/...". It does so by simply
> calling String.replace, which replaces the first instance of "/solr" in the
> URL with "/api".
>
> In the case where the host's address starts with "solr" and the HTTP protocol
> is appended, this call changes the address for the request. Example:
> if baseUrl is "http://solr-host.com/8983/solr";, this call will change to
> "http:/api-host.com:8983/solr"
>
> We should use a regex pattern to ensure that we're replacing the correct
> portion of the URL.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
