[
https://issues.apache.org/jira/browse/SOLR-13727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921766#comment-16921766
]
Lucene/Solr QA commented on SOLR-13727:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} SOLR-13727 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13727 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12979259/SOLR-13727.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/547/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> V2Requests: HttpSolrClient replaces first instance of "/solr" with "/api"
> instead of using regex pattern
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13727
> URL: https://issues.apache.org/jira/browse/SOLR-13727
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java, v2 API
> Affects Versions: 8.2
> Reporter: Megan Carey
> Priority: Major
> Labels: easyfix, patch
> Attachments: SOLR-13727.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When the HttpSolrClient is formatting a V2Request, it needs to change the
> endpoint from the default "/solr/..." to "/api/...". It does so by simply
> calling String.replace, which replaces the first instance of "/solr" in the
> URL with "/api".
>
> In the case where the host's address starts with "solr" and the HTTP protocol
> is appended, this call changes the address for the request. Example:
> if baseUrl is "http://solr-host.com/8983/solr";, this call will change to
> "http:/api-host.com:8983/solr"
>
> We should use a regex pattern to ensure that we're replacing the correct
> portion of the URL.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
