[ 
https://issues.apache.org/jira/browse/SOLR-13727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922988#comment-16922988
 ] 

ASF subversion and git services commented on SOLR-13727:
--------------------------------------------------------

Commit 8c796b5f463c9c2529f29f317aa2c847f390a174 in lucene-solr's branch 
refs/heads/master from Megan Carey
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8c796b5 ]

SOLR-13727: Bug fix for V2Request handling in HttpSolrClient

 Using regex to validate baseUrl and replace path for V2Requests

 Changed to using Java.net.URL for validation + path replacement


> V2Requests: HttpSolrClient replaces first instance of "/solr" with "/api" 
> instead of using regex pattern
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-13727
>                 URL: https://issues.apache.org/jira/browse/SOLR-13727
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: clients - java, v2 API
>    Affects Versions: 8.2
>            Reporter: Megan Carey
>            Priority: Major
>              Labels: easyfix, patch
>         Attachments: SOLR-13727.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> When the HttpSolrClient is formatting a V2Request, it needs to change the 
> endpoint from the default "/solr/..." to "/api/...". It does so by simply 
> calling String.replace, which replaces the first instance of "/solr" in the 
> URL with "/api".
>  
> In the case where the host's address starts with "solr" and the HTTP protocol 
> is appended, this call changes the address for the request. Example:
> if baseUrl is "http://solr-host.com/8983/solr";, this call will change to 
> "http:/api-host.com:8983/solr"
>  
> We should use a regex pattern to ensure that we're replacing the correct 
> portion of the URL.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to