jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324098325
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -156,6 +187,10 @@ public void collect(int doc) throws IOException {
pqTop.score = score;
pqTop = pq.updateTop();
updateMinCompetitiveScore(scorer);
Review comment:
We should propagate the global minimum score to the underlying scorer
(`Scorer#setMinCompetitiveScore`) too. The optimization above that compares
the current doc with the global minimum score is a good one but propagating the
global minimum score should be more effective since it will allow skipping hits
directly in the scorer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
