jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130957
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -89,8 +104,12 @@ public void collect(int doc) throws IOException {
pqTop.score = score;
pqTop = pq.updateTop();
updateMinCompetitiveScore(scorer);
- }
+ if (bottomValueChecker != null &&
bottomValueChecker.isGlobalBottomValueAvailable()) {
Review comment:
Same here, this should move `updateMinCompetitiveScore`, as is it doesn't
respect the total hits threshold and the bottom values might be greater than
the local bottom score.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
