jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324105474
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -156,6 +187,10 @@ public void collect(int doc) throws IOException {
pqTop.score = score;
pqTop = pq.updateTop();
updateMinCompetitiveScore(scorer);
Review comment:
I don't understand how it could break this test. We should propagate the min
score only if the total hit threshold is reached and this test indexes 100 docs
only while the default threshold is 10,000. So we should never skip hits in
this test, am I missing something ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
