Thanks Adrien. My apologies for the inconvenience . --Noble
On Thu, Dec 19, 2019 at 8:04 AM Adrien Grand <[email protected]> wrote: > > Thanks Cassandra for finding this missing commit. I'll start a new RC > tomorrow morning EU time. > > On Wed, Dec 18, 2019 at 9:21 PM Alexandre Rafalovitch <[email protected]> > wrote: >> >> If there is a respin, maybe the Changenotes (for Solr) can be fixed too: >> 1) First entry under Upgrade Notes is missing JIRA and probably does >> not need to include the full class path >> 2) Optimization section can probably be skipped as it just has "no >> changes" entry >> 3) Couple of JIRAs are missing contributor attributions (is it >> compulsory? I don't know.) >> >> Also Lucene's one under "build" section is missing one JIRA number. >> >> Regards, >> Alex. >> >> On Wed, 18 Dec 2019 at 14:20, Noble Paul <[email protected]> wrote: >> > >> > I'm so sorry to come at this moment and tell you that one of the >> > critical bug fixes I made to master was not ported to 8x and 8.4. >> > >> > This breaks a critical functionality of package loading feature. >> > Is it possible to do a respin? >> > https://github.com/apache/lucene-solr/commit/f98555854cbdb9d396c34a93fde9c1610df74882#diff-04f78a3e0960a743f6b4267e2d0f7f49 >> > >> > >> > On Thu, Dec 19, 2019 at 6:11 AM Adrien Grand <[email protected]> wrote: >> > > >> > > Hi Gus, >> > > >> > > If the test is flaky, would you mind annotating it with "@BadApple"? It >> > > will make sure this test doesn't get in the way of building or voting on >> > > a release until the test is fixed. >> > > >> > > On Wed, Dec 18, 2019 at 3:52 PM Gus Heck <[email protected]> wrote: >> > >> >> > >> Hi Mkhail, This is a known flakey test (mine, it's on my to do list). >> > >> Seems to have got slightly more flakey recently possibly because other >> > >> tests have got better at using up CPU?. The flake here is that the code >> > >> in the test didn't manage to wait long enough before running the >> > >> assertion. This failure does not represent an issue with anything other >> > >> than the test. >> > >> >> > >> On Wed, Dec 18, 2019 at 1:06 AM Mikhail Khludnev <[email protected]> >> > >> wrote: >> > >>> >> > >>> I've got >> > >>> >> > >>> 2> NOTE: reproduce with: ant test >> > >>> -Dtestcase=DimensionalRoutedAliasUpdateProcessorTest >> > >>> -Dtests.method=testTimeCat -Dtests.seed=D05700662AF3B95B >> > >>> -Dtests.locale=en-GB -Dtests.timezone=Australia/North -Dt >> > >>> >> > >>> ests.asserts=true -Dtests.file.encoding=ISO-8859-1 >> > >>> >> > >>> [00:42:59.083] FAILURE 29.4s J1 | >> > >>> DimensionalRoutedAliasUpdateProcessorTest.testTimeCat <<< >> > >>> >> > >>> > Throwable #1: java.lang.AssertionError: expected:<10> but was:<9> >> > >>> >> > >>> > at >> > >>> __randomizedtesting.SeedInfo.seed([D05700662AF3B95B:E9AF41D56AD2F530]:0) >> > >>> >> > >>> > at org.junit.Assert.fail(Assert.java:88) >> > >>> >> > >>> > at org.junit.Assert.failNotEquals(Assert.java:834) >> > >>> >> > >>> > at org.junit.Assert.assertEquals(Assert.java:645) >> > >>> >> > >>> > at org.junit.Assert.assertEquals(Assert.java:631) >> > >>> >> > >>> > at >> > >>> org.apache.solr.update.processor.DimensionalRoutedAliasUpdateProcessorTest.assertCatTimeInvariants(DimensionalRoutedAliasUpdateProcessorTest.java:678) >> > >>> >> > >>> > at >> > >>> org.apache.solr.update.processor.DimensionalRoutedAliasUpdateProcessorTest.testTimeCat(DimensionalRoutedAliasUpdateProcessorTest.java:196) >> > >>> >> > >>> >> > >>> which didn't reproduce to me when I retry. >> > >>> >> > >>> +0 >> > >>> >> > >>> On Tue, Dec 17, 2019 at 9:23 PM Adrien Grand <[email protected]> wrote: >> > >>>> >> > >>>> Please vote for release candidate 1 for Lucene/Solr 8.4.0 >> > >>>> >> > >>>> The artifacts can be downloaded from: >> > >>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b207018670 >> > >>>> >> > >>>> You can run the smoke tester directly with this command: >> > >>>> >> > >>>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >> > >>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b207018670 >> > >>>> >> > >>>> The vote will be open for at least 3 working days, i.e. until >> > >>>> 2019-12-20 19:00 UTC. >> > >>>> >> > >>>> [ ] +1 approve >> > >>>> [ ] +0 no opinion >> > >>>> [ ] -1 disapprove (and reason why) >> > >>>> >> > >>>> Here is my +1 >> > >>>> >> > >>>> -- >> > >>>> Adrien >> > >>> >> > >>> >> > >>> >> > >>> -- >> > >>> Sincerely yours >> > >>> Mikhail Khludnev >> > >> >> > >> >> > >> >> > >> -- >> > >> http://www.needhamsoftware.com (work) >> > >> http://www.the111shift.com (play) >> > > >> > > >> > > >> > > -- >> > > Adrien >> > >> > >> > >> > -- >> > ----------------------------------------------------- >> > Noble Paul >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > -- > Adrien -- ----------------------------------------------------- Noble Paul --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
