It is not depending on timing -- it just includes the timing in its output (it basically diffs the response message with and without CBs).
Atri On Fri, Jun 11, 2021 at 8:02 PM Michael Sokolov <[email protected]> wrote: > > I ran the smoketester (FWIW I always have to pass --tmp-dir /local/tmp > because my /tmp is not big enough for this thing), but it failed for > me: > > [junit4] Tests with failures [seed: D9C1F978D5A8B019]: > [junit4] - > org.apache.solr.util.TestCircuitBreaker.testResponseWithCBTiming > > Have to say, a test with the word "Timing" in the name makes me wary. > I don't know what the test does exactly, but if it is sensitive to > timing, that is a recipe for unreliability. Maybe it is just including > timing in the response? > > I re-ran the test with ant test -Dtestcase=TestCircuitBreaker > -Dtests.seed=D9C1F978D5A8B019 and it passed ... > > On Fri, Jun 11, 2021 at 9:48 AM Robert Muir <[email protected]> wrote: > > > > I nuked all my settings and am rerunning with all defaults. I'll > > report back what happens/upload log when/if it finishes or fails. > > > > On Fri, Jun 11, 2021 at 9:45 AM Michael Sokolov <[email protected]> wrote: > > > > > > I tried to comment on the JIRA, but it seems to be timing out. Now > > > when I go back, SOLR issues are marked as "You can't view this issue > > > It may have been deleted or you don't have permission to view it." > > > Waat? > > > > > > Anyway, Robert you suggested there that maybe the problem is being > > > surfaced by using a different working directory for the tests. Do you > > > think that the tests need to be fixed so that they work with this > > > tmp.workDir parameter? What if you were to cd to the place you want to > > > use as the working dir and call the smokeTester from there? > > > > > > > > > On Fri, Jun 11, 2021 at 9:29 AM Mayya Sharipova > > > <[email protected]> wrote: > > > > > > > > Thanks very much Robert for detailed investigations, and thanks Jan for > > > > your tests. > > > > > > > > I will sort out the problem with my GPG key, but I am not sure what to > > > > do with this SOLR-15473. I've run the smoker test again, and it passed > > > > on my Mac again: SUCCESS! [1:00:03.751500] > > > > Would appreciate more guidance, if we need to resolve SOLR-15473 before > > > > 8.9 release. > > > > > > > > > > > > On Fri, Jun 11, 2021 at 8:09 AM Robert Muir <[email protected]> wrote: > > > >> > > > >> Dude, if you can vote +1 when the smoketester passes, then I can vote > > > >> -1 when it fails. This is my vote, not your vote. You don't get to > > > >> decide about it, or change it in any way. > > > >> > > > >> On Fri, Jun 11, 2021 at 8:04 AM Jan Høydahl <[email protected]> > > > >> wrote: > > > >> > > > > >> > Does it reproduce for you? Are you suspecting a bug in Solr that we > > > >> > cannot ship, or only a bug in the smoketester py itself? The -1 > > > >> > should be about the released bits, not about other tooling? > > > >> > My JVM is OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, > > > >> > mixed mode) > > > >> > > > > >> > Jan > > > >> > > > > >> > > 11. jun. 2021 kl. 13:48 skrev Robert Muir <[email protected]>: > > > >> > > > > > >> > > Jan, I'm using the same automated smoketester as everyone else. It > > > >> > > fails, so my vote is -1. > > > >> > > > > > >> > > On Fri, Jun 11, 2021 at 7:22 AM Jan Høydahl > > > >> > > <[email protected]> wrote: > > > >> > >> > > > >> > >> Tested on MacOS (Intel), No other verification than smoketester > > > >> > >> done > > > >> > >> > > > >> > >> SUCCESS! [1:08:19.953492] > > > >> > >> > > > >> > >> +1 > > > >> > >> > > > >> > >> Robert - not sure if one test-run failure should cancel the > > > >> > >> build. Our smoketester and tests are sometimes a bit picky, and > > > >> > >> does not mean that the artifacts are faulty. > > > >> > >> > > > >> > >> Jan > > > >> > >> > > > >> > >> 11. jun. 2021 kl. 04:14 skrev Mayya Sharipova > > > >> > >> <[email protected]>: > > > >> > >> > > > >> > >> Please vote for release candidate 1 for Lucene/Solr 8.9.0 > > > >> > >> > > > >> > >> The artifacts can be downloaded from: > > > >> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.9.0-RC1-rev05c8a6f0163fe4c330e93775e8e91f3ab66a3f80 > > > >> > >> > > > >> > >> You can run the smoke tester directly with this command: > > > >> > >> > > > >> > >> python3 -u dev-tools/scripts/smokeTestRelease.py \ > > > >> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.9.0-RC1-rev05c8a6f0163fe4c330e93775e8e91f3ab66a3f80 > > > >> > >> > > > >> > >> The vote will be open for at least 72 hours i.e. until 2021-06-16 > > > >> > >> 02:00 UTC. > > > >> > >> > > > >> > >> [ ] +1 approve > > > >> > >> [ ] +0 no opinion > > > >> > >> [ ] -1 disapprove (and reason why) > > > >> > >> > > > >> > >> Here is my +1 > > > >> > >> SUCCESS! [0:01:43.815224] > > > >> > >> > > > >> > >> > > > >> > > > > > >> > > --------------------------------------------------------------------- > > > >> > > To unsubscribe, e-mail: [email protected] > > > >> > > For additional commands, e-mail: [email protected] > > > >> > > > > > >> > > > > >> > > > > >> > --------------------------------------------------------------------- > > > >> > To unsubscribe, e-mail: [email protected] > > > >> > For additional commands, e-mail: [email protected] > > > >> > > > > >> > > > >> --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: [email protected] > > > >> For additional commands, e-mail: [email protected] > > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > -- Regards, Atri Apache Concerted --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
