Here is the change adding the 'org.apache.*' prefix, Uwe: https://github.com/apache/lucene/pull/487
I verified that Luke starts in the rebuilt distribution and that module names show org.apache.* prefixes. Dashes are not allowed in modules so Lucene artifacts using them (spatial-extras, test-framework, backward-codecs) use an underscore in place of the dash. Dawid On Mon, Nov 29, 2021 at 7:23 PM Dawid Weiss <[email protected]> wrote: > > Dear Uwe, > > > I did not notice this because it was somehow hidden. > > It was not hidden, Uwe. It was right there in the issue that > introduced it, along with a comment that it was a deliberate decision > (mine). > > > In every build.gradle file define the module name explicit using an ext > > property for the "Automatic Module Name" JAR manifest, don't use regex > > replace on the filesystem path of the gradle build. > > I disagree with you - convention over configuration. If you derive the > module name from the project path, it's simpler and easier to use. And > nothing will break -- if you change the layout of folders, you'd break > compilation and you'd have to alter the naming convention in that > (one!) place as well. The simpler it is, the better. I would even > insist on renaming module folders to what the package structure > already uses (underscore instead of the dash) so that it's consistent > everywhere. > > > If you remove the "lucene/" directory from the gradle build, the module > > name changes. This is not acceptable! > > If you do that, everything will break and you'd have to change a lot > more than just module names... > > I'll provide a patch adding org.apache. prefix but I don't agree on > scattering module names in each and every module - this is irrelevant > and unnecessary duplication of what can be done in a simple way (and > we already do it for JAR names, Maven artifacts, etc...). > > D. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
