> > In every build.gradle file define the module name explicit using an ext > property for the "Automatic Module Name" JAR manifest, don't use regex > replace on the filesystem path of the gradle build. > > I disagree with you - convention over configuration. If you derive the > module name from the project path, it's simpler and easier to use. And > nothing will break -- if you change the layout of folders, you'd break > compilation and you'd have to alter the naming convention in that > (one!) place as well. The simpler it is, the better. I would even > insist on renaming module folders to what the package structure > already uses (underscore instead of the dash) so that it's consistent > everywhere.
At some point we have to hardcode them into the module-info.java. But OK, it is fine, if we do it like that: https://github.com/apache/lucene/blob/main/gradle/maven/publications-maven.gradle#L59-L60 I don't think we need the "archivesBaseName", because this repeats "lucene" prefix, but the project name and project group should be appended with "." and al dashes replaced by "_". Uwe --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
