Thanks for doing this!! Give me a few minutes, I'll verify everything passes on linux, and review it locally. And I agree, sooner than later is better as it will conflict with anything and everything.
Due to the expected noise of the import statements, the change is so large that it makes the Github UI unresponsive, so I'll review the diff locally while check runs. On Mon, Dec 20, 2021 at 9:55 AM Dawid Weiss <dawid.we...@gmail.com> wrote: > > > Hello everyone, > > I've completed the task of getting the test framework to not share any > packages with Lucene core - this is here: > > https://issues.apache.org/jira/browse/LUCENE-10301 > https://github.com/apache/lucene/pull/551 > > Basically everything remains the same, except for the changed package prefix. > The patch is rather large because it cuts across all of the code (imports, > mostly). There are also some minor tweaks to expose package-private internals > in the core to the test framework, now residing in a different package. > > Tests pass for me but I could use a pair of eyes on the patch. This will be > rather annoying for backports (if you change anything in the test framework > itself) so I'd like to apply it to 9x and main. Soon-ish, if there are no > objections. > > Dawid --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
