I wouldn't have thought to do such a change in a minor release, but I suppose for tests it's fine.
~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Dec 21, 2021 at 9:10 AM Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > TortoiseGit's Viewer for diffs also helps well. But I just quicky skimmed > through it and only stopped at classes where different changes to imports > were done. > > Thanks, > Uwe > > Am 21. Dezember 2021 14:01:15 UTC schrieb Robert Muir <rcm...@gmail.com>: >> >> On Tue, Dec 21, 2021 at 8:20 AM Mark Jens <mark.r.j...@gmail.com> wrote: >> >>> >>> You can use >>> https://patch-diff.githubusercontent.com/raw/apache/lucene/pull/551.diff to >>> render plain text and keep the browser responsive. >>> Another option is >>> https://patch-diff.githubusercontent.com/raw/apache/lucene/pull/551.patch >>> to see each commit separately. >>> >>> >> Thank you Mark. >> >> This does work easily for a large diff, and I get colored diff if I >> load it in vim (syntax on/set background=dark). >> But personally, especially for such a large diff, I get a much better >> color scheme for reviewing via 'git diff'. >> Seems I need to tweak the vim colors better for "downloaded diff" to >> be more useful... >> >> In any case, fetching Dawid's remote branch and testing it out myself >> was worth the trouble. It found a bug >> (https://issues.apache.org/jira/browse/LUCENE-10331) >> ------------------------------ >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> -- > Uwe Schindler > Achterdiek 19, 28357 Bremen > https://www.thetaphi.de >
