Hi Tomoko,
I also tested that the links in CHANGES.txt also work with issues. That
is confirmed. Baysically for Github there's an automatic redirect if you
link to an ID as PR and in reality it is an issue:
E.g.,
https://ci-builds.apache.org/job/Lucene/job/Lucene-Artifacts-main/javadoc/changes/Changes.html;
see 9.4, bugfix 5. It has the link
1. LUCENE-10665
<http://issues.apache.org/jira/browse/LUCENE-10665>,GITHUB#11701
<https://github.com/apache/lucene/pull/11701>: Fix classloading
deadlock in analysis factories / AnalysisSPILoader initialization.
(Uwe Schindler)
This works well, but we should maybe change the CHANGES.txt perl script
to always link using the URL pattern "/issue/" instead of "/pull/". I
think "issue" is the more generic term (I see PR as a special case of
issue).
The PR to change this would be a one-liner.
Uwe
Am 26.08.2022 um 04:09 schrieb Tomoko Uchida:
Hi Uwe,
thanks for testing.
> But now my question: To contact the original bug submitter I acnt do
> anything in JIRA anymore. That's fine, but when do we add the automated
> message to all issues with a reference to the new Github URL? This would
> help to inform the user like "now look here.... user looks github and
> sees: issue resolved".
The script is already ready, but I think we need to silence Jira
notifications to issues@ before that.
Only Jira admins can change the notification schema. I am waiting for
https://issues.apache.org/jira/browse/INFRA-23625 is resolved.
Tomoko
2022年8月26日(金) 1:35 Uwe Schindler <u...@thetaphi.de>:
Hi Tomoko!
Great and works well! I also tested backporting with cherry-picks on
issue https://github.com/apache/lucene/issues/11701:
- The linked PR (https://github.com/apache/lucene/pull/11718) was
main
only. In the squash merge message I added "This fixes #11701."
- After merging the PR the related issue was closed too (standard
behaviour)
- I then used my desktop machine and cherry picked the squash commit
using my TortoiseGit by opening log, switching to main branch, right
clicking the commit and choose cherry pick. This went throough
without
any problems.
- The merge commit was successfully also linked in both the PR and
the
issue.
So all works as it should. No need to create separate PRs for 9.x. I
look into backporting
https://github.com/apache/lucene/issues/11701 to
8.11 branch (if the original author responds). Of course ten the
links
won't work unless you add repo name.
But now my question: To contact the original bug submitter I acnt do
anything in JIRA anymore. That's fine, but when do we add the
automated
message to all issues with a reference to the new Github URL? This
would
help to inform the user like "now look here.... user looks github and
sees: issue resolved".
Uwe
Am 25.08.2022 um 13:04 schrieb Dawid Weiss:
> It looks great, thank you for this monumental effort, Tomoko.
>
> Dawid
>
> On Wed, Aug 24, 2022 at 9:19 PM Tomoko Uchida
> <tomoko.uchida.1...@gmail.com> wrote:
>> <Progress report and announcement>
>>
>> Issue migration has been completed (except for minor cleanups).
>> This is the Jira -> GitHub issue number mapping for possible
future usage.
>>
https://github.com/apache/lucene-jira-archive/blob/main/migration/mappings-data/issue-map.csv.20220823_final
>>
>> GitHub issue is now fully available for all issues.
>> For issue label management (e.g. "fix-version"), please review
this manual.
>>
https://github.com/apache/lucene/blob/main/dev-docs/github-issues-howto.md
>>
>> Tomoko
>>
>>
>> 2022年8月22日(月) 19:46 Michael McCandless
<luc...@mikemccandless.com>:
>>
>>> Wooot! Thank you so much Tomoko!!
>>>
>>> Mike
>>>
>>> On Mon, Aug 22, 2022 at 6:44 AM Tomoko Uchida <
>>> tomoko.uchida.1...@gmail.com> wrote:
>>>
>>>> <Progress report and announcement>
>>>>
>>>> Issue migration has been started. Jira is now read-only.
>>>>
>>>> GitHub issue is available for new issues.
>>>>
>>>> - You should open new issues on GitHub. E.g.
>>>> https://github.com/apache/lucene/issues/1078
>>>> - Do not touch issues that are in the middle of migration,
please. E.g.
>>>> https://github.com/apache/lucene/issues/1072
>>>> - While you cannot break these issues, migration scripts can
>>>> modify/overwrite your comments on the issues.
>>>> - Pull requests are not affected. You can open/update PRs as
usual.
>>>> Please let me know if you have any trouble with PRs.
>>>>
>>>>
>>>> Tomoko
>>>>
>>>>
>>>> 2022年8月18日(木) 18:23 Tomoko Uchida
<tomoko.uchida.1...@gmail.com>:
>>>>
>>>>> Hello all,
>>>>>
>>>>> The Lucene project decided to move our issue tracking system
from Jira
>>>>> to GitHub and migrate all Jira issues to GitHub.
>>>>>
>>>>> We start issue migration on Monday, August 22 at 8:00 UTC.
>>>>> 1) We make Jira read-only before migration. You cannot
update existing
>>>>> issues until the migration is completed.
>>>>> 2) You can use GitHub for opening NEW issues or pull
requests during
>>>>> migration.
>>>>>
>>>>> Note that issues should be raised in Jira at this moment,
although
>>>>> GitHub issue is already enabled in the Lucene repository.
>>>>> Please do not raise issues in GitHub until we let you know
that GitHub
>>>>> issue is officially available. We immediately close any
issues on GitHub
>>>>> until then.
>>>>>
>>>>> Here are the detailed plan/migration steps.
>>>>> https://github.com/apache/lucene-jira-archive/issues/7
>>>>>
>>>>> Tomoko
>>>>>
>>>> --
>>> Mike McCandless
>>>
>>> http://blog.mikemccandless.com
>>>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail:u...@thetaphi.de
